Expand AVE to arrays of different types #26372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Engin Kayraklioglu <[email protected]>
|
Note that on a screenshare, I asked Michael to attempt the fix here. That didn't seem to help him then. There might be something more complicated in his case that I am not able to reproduce yet. |
Signed-off-by: Engin Kayraklioglu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Michael has bumped into a case where AVE wasn't firing when arrays are of different type (block vs DR particularly). That seems to be because of a check I added for caution in the first PR, which looks like it was easy to remove.
This PR also adds tests, but note that Cyclic vs DR is still not supported. I don't think this is an AVE limitation -- such bulk transfer are probably not supported already.
Test